Skip to content

Enable options to index creation on maps (solves issue 122)#133

Merged
sl-at-ibm merged 3 commits intomainfrom
SL-issue122-MapIndexesOptions
Apr 14, 2026
Merged

Enable options to index creation on maps (solves issue 122)#133
sl-at-ibm merged 3 commits intomainfrom
SL-issue122-MapIndexesOptions

Conversation

@sl-at-ibm
Copy link
Copy Markdown
Collaborator

Fixes #122 .

This PR enables passing the options (ascii/normalize/caseSensitive) to index creation for a map table column.

Along the way:

  1. xmldoc params are aligned with the actual methods in TableIndexBuilder (+their text added where it was missing);
  2. said options are encapsulated in the proper TableIndexOptions to avoid three anonymous booleans in a row (incl. non-table index creation). this is a breaking change (see tests), which anyway we have discussed in 122 already.
  3. added tests for this index creation pattern.

Note: as a matter of fact, the Data API accepts these options when creating keys/values indexes only, whereas for "entries creation" there is only one allowed combination of the three bools (the default), which renders it unnecessary to specify them. However, preventing the user from supplying the options is probably not a task for the client under the philosophy of not duplicating server-side guardrails. Hence no checks are performed ("if mapindextype == entries ...").

@sl-at-ibm sl-at-ibm requested a review from toptobes April 10, 2026 17:01
@sl-at-ibm
Copy link
Copy Markdown
Collaborator Author

@a-random-steve FYI ^

@sl-at-ibm sl-at-ibm marked this pull request as ready for review April 10, 2026 20:36
@sl-at-ibm sl-at-ibm added this pull request to the merge queue Apr 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026
@sl-at-ibm sl-at-ibm force-pushed the SL-issue122-MapIndexesOptions branch from 53b596a to a4a4ee8 Compare April 14, 2026 08:04
@sl-at-ibm sl-at-ibm added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 6bef2bc Apr 14, 2026
7 checks passed
@sl-at-ibm sl-at-ibm deleted the SL-issue122-MapIndexesOptions branch April 14, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow (ascii/caseSensitive/normalize) options for Map indexes (at least keys&values; also entries is fine)

2 participants